[WebLink] Escape double quotes in attributes values #40209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shouldn't this be escaped with |
or maybe not if this is for HTTP headers? any link to the relevant part of the spec? |
|
https://tools.ietf.org/html/rfc5988 says quoted-string:
|
nicolas-grekas
approved these changes
Feb 16, 2021
chalasr
approved these changes
Feb 16, 2021
fabpot
approved these changes
Feb 16, 2021
|
Thank you @fancyweb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the attribute value contains a double quote, the serialized value is invalid:
</foo>; rel="alternate"; title="foo " bar". Ideally we would useaddcslashesbut we can't because users that already pass escaped values would then be impacted.