Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MockResponse total_time should not be simulated when provided #40239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolas-grekas merged 1 commit into from
Feb 26, 2021
Merged

MockResponse total_time should not be simulated when provided #40239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix: MockResponse total_time should not be simulated when provided
  • Loading branch information
@pvgnd
pvgnd committed Feb 25, 2021
commit 8dada95cbf28bfa9404c6ea884eae8d9b0a319b2
8 changes: 4 additions & 4 deletions src/Symfony/Component/HttpClient/Response/MockResponse.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,8 @@ private static function writeRequest(self $response, array $options, ResponseInt
$response->info['size_upload'] = 0.0;
}

// simulate "total_time" if it is set
if (isset($response->info['total_time'])) {
// simulate "total_time" if it is not set
if (!isset($response->info['total_time'])) {
$response->info['total_time'] = microtime(true) - $response->info['start_time'];
}

Expand Down Expand Up @@ -260,7 +260,7 @@ private static function readResponse(self $response, array $options, ResponseInt
'http_code' => $response->info['http_code'],
] + $info + $response->info;

if (isset($response->info['total_time'])) {
if (!isset($response->info['total_time'])) {
$response->info['total_time'] = microtime(true) - $response->info['start_time'];
}

Expand All @@ -287,7 +287,7 @@ private static function readResponse(self $response, array $options, ResponseInt
$offset = \strlen($body);
}

if (isset($response->info['total_time'])) {
if (!isset($response->info['total_time'])) {
$response->info['total_time'] = microtime(true) - $response->info['start_time'];
}
Comment on lines 290 to 292
Copy link
Copy Markdown
Contributor

@javespi javespi Feb 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering why do we need this if-block twice: https://github.com/symfony/symfony/pull/40239/files#diff-7a4f5b316b06a89c94ca2309890e5c3ce140c4b97f92b1ecb6a640a8c97c259aL284-L286

Copy link
Copy Markdown
Member

@nicolas-grekas nicolas-grekas Feb 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To measure the time that passes between the two calls.


Expand Down
18 changes: 18 additions & 0 deletions src/Symfony/Component/HttpClient/Tests/Response/MockResponseTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,24 @@
*/
class MockResponseTest extends TestCase
{
public function testTotalTimeShouldBeSimulatedWhenNotProvided()
{
$response = new MockResponse('body');
$response = MockResponse::fromRequest('GET', 'https://example.com/file.txt', [], $response);

$this->assertNotNull($response->getInfo('total_time'));
$this->assertGreaterThan(0.0, $response->getInfo('total_time'));
}

public function testTotalTimeShouldNotBeSimulatedWhenProvided()
{
$totalTime = 4.2;
$response = new MockResponse('body', ['total_time' => $totalTime]);
$response = MockResponse::fromRequest('GET', 'https://example.com/file.txt', [], $response);

$this->assertEquals($totalTime, $response->getInfo('total_time'));
}

public function testToArray()
{
$data = ['color' => 'orange', 'size' => 42];
Expand Down