Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Console] Handle calls to mb_ functions with non string arguments #40272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2021
Merged

[Console] Handle calls to mb_ functions with non string arguments #40272

merged 1 commit into from
Feb 22, 2021

Conversation

Yopai
Copy link
Contributor

@Yopai Yopai commented Feb 22, 2021 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40200
License MIT
Doc PR no

In PHP8.1, a number of functions who were accepting null arguments will only accept
string ones.
(see https://wiki.php.net/rfc/deprecate_null_to_scalar_internal_arg)

In the polyfill, mb_* functions are already declared with a strict type checking of "string".

Therefore, it is necessary to get rid of the use of non string arguments when calling mb_* functions,
so that it won't break when either using the polyfill,or future php8 versions.

In every call where the argument may not be a string, this commit enforces the string type of the argument (with transtyping)

--- For reviewers

  • I generally don't like transtyping, but found it was the more "secure" way (on a non-BC point of view) here.
    Specially in Console/Helper/Table.php, where $cell can be an object (there are 2 "$cell instanceof ... tests)
    However, where the argument can already be either null or string (and not anything else), there may a beter approach ?

  • It's the first time I send a PR on symfony, so don't hesitate pointing me to thinks I've forgotten to done.

@carsonbot carsonbot added this to the 4.4 milestone Feb 22, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.x branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title [console] [error_handler] [http_foundation] [mime] [translation] [var_dumper] [form] Handle calls to mb_ functions with non string arguments [Console][Form][Mime][Translation] [error_handler] [http_foundation] [var_dumper] Handle calls to mb_ functions with non string arguments Feb 22, 2021
@carsonbot carsonbot changed the title [Console][Form][Mime][Translation] [error_handler] [http_foundation] [var_dumper] Handle calls to mb_ functions with non string arguments [Console][ErrorHandler][Form][HttpFoundation][Mime][Translation][VarDumper] [error_handler] [http_foundation] [var_dumper] Handle calls to mb_ functions with non string arguments Feb 22, 2021
@derrabus derrabus changed the title [Console][ErrorHandler][Form][HttpFoundation][Mime][Translation][VarDumper] [error_handler] [http_foundation] [var_dumper] Handle calls to mb_ functions with non string arguments [Console][ErrorHandler][Form][HttpFoundation][Mime][Translation][VarDumper] Handle calls to mb_ functions with non string arguments Feb 22, 2021
derrabus
derrabus requested changes Feb 22, 2021
View reviewed changes
@derrabus
Copy link
Member

Please also have a look at the CS errors fabbot reported.

@Yopai Yopai force-pushed the Change_mb_null_args branch from efdc0f9 to d0938cf Compare February 22, 2021 11:54
@Yopai
Copy link
Contributor Author

Yopai commented Feb 22, 2021

Thanks.
I fixed not-useful tests, and fix CS for what I modified.
And then I fixed use of shorttag, that fabbot indicated too.
(I pushed the commits again, is there anything else I have to do ?)

derrabus
derrabus requested changes Feb 22, 2021
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I should've been more precise. You don't need to fix fabbot errors you haven't caused. In this case, the short tags were a false positive. Can you restore them?

@Yopai Yopai force-pushed the Change_mb_null_args branch from 1c0f6b8 to 250ef7d Compare February 22, 2021 13:26
@Yopai
Copy link
Contributor Author

Yopai commented Feb 22, 2021

No worry (that's why I made it in a separate commit :) )
Done !

derrabus
derrabus reviewed Feb 22, 2021
View reviewed changes
nicolas-grekas
nicolas-grekas reviewed Feb 22, 2021
View reviewed changes
nicolas-grekas
nicolas-grekas reviewed Feb 22, 2021
View reviewed changes
nicolas-grekas
nicolas-grekas reviewed Feb 22, 2021
View reviewed changes
@Yopai Yopai force-pushed the Change_mb_null_args branch 2 times, most recently from 3830c75 to 4670282 Compare February 22, 2021 14:42
nicolas-grekas
nicolas-grekas reviewed Feb 22, 2021
View reviewed changes
@Yopai Yopai force-pushed the Change_mb_null_args branch 2 times, most recently from 8459b70 to 274f7ac Compare February 22, 2021 17:16
@Yopai Yopai requested a review from nicolas-grekas February 22, 2021 17:17
@Yopai
In calls to mb_ functions, silently transform arg into string
ac45be2 
In PHP8, a number of functions who were accepting null arguments will only accept
string ones.

In the polyfill, mb_* functions are declared with a trict type checking of "string".

Therefore, we deprecate the use of non string arguments, so that it won't break when either using the polyfill,
or future php8 versions.
@Yopai Yopai force-pushed the Change_mb_null_args branch from 274f7ac to ac45be2 Compare February 22, 2021 17:49
@Yopai Yopai changed the title [Console][ErrorHandler][Form][HttpFoundation][Mime][Translation][VarDumper] Handle calls to mb_ functions with non string arguments [Console] Handle calls to mb_ functions with non string arguments Feb 22, 2021
@carsonbot carsonbot changed the title [Console] Handle calls to mb_ functions with non string arguments [Console][ErrorHandler][Form][HttpFoundation][Mime][Translation][VarDumper] Handle calls to mb_ functions with non string arguments Feb 22, 2021
@nicolas-grekas nicolas-grekas changed the title [Console][ErrorHandler][Form][HttpFoundation][Mime][Translation][VarDumper] Handle calls to mb_ functions with non string arguments [Console] Handle calls to mb_ functions with non string arguments Feb 22, 2021
@nicolas-grekas
Copy link
Member

Thank you @Yopai.

@nicolas-grekas nicolas-grekas merged commit b5dc77e into symfony:4.4 Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@xabbuh xabbuh Awaiting requested review from xabbuh

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
Bug Console Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Yopai @carsonbot @derrabus @nicolas-grekas