[HttpKernel] Add is_file() check before include #40516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to include a file that doesn't exist issues a warning. Doing an is_file check beforehand should prevent those warnings.
nicolas-grekas
approved these changes
Mar 19, 2021
|
I suppose you're having the issue because your error handler doesn't correctly handle the |
|
Thank you @burned42. |
Thanks for the hint, I didn't notice any (other) issues yet regarding my error handler, but I'll recheck my configs 👍 Also thanks for reviewing/merging so fast :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently noticed that on every deployment I got warnings reported by sentry from the
cache:clearcommand.In
Symfony\Component\HttpKernel\Kernelline 469(on 4.4 it's on line 536)
This is because the code tries to include the
$cachePathwithout checking if it exists/is a file first. It seems like something similar was fixed some time ago already (#27249) some lines above.This PR fixes the mentioned warnings for me.
I'm running on Symfony 5.2.5 at the moment, but the docs said that bugfixes should target branch 4.4 and new features should target 5.x, and I guess this could rather be seen as a bugfix than a new feature, so I branched off of 4.4 and also set this as target for the PR, I hope that's correct.