[Security] Use concrete UserInterface and UserProviderInterface classes in the tests #40609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
chalasr
approved these changes
Mar 28, 2021
Nyholm
approved these changes
Mar 28, 2021
This allows the tests to automatically adapt for changes in the UserInterface and UserProviderInterface in 5.x
f650709 to
89d9de2
Compare
|
Thanks for the quick reviews Tobias and Robin :) |
chalasr
added a commit
that referenced
this pull request
Mar 28, 2021
…erj) This PR was merged into the 5.2 branch. Discussion ---------- [Security] Use more concrete user classes in tests | Q | A | ------------- | --- | Branch? | 5.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Similar to #40609. #40145 keeps resisting... this should be the last mocked user & user provider in the 5.2 tests, looking at the failing deps=high build. Commits ------- 631408b [Security] Use more concrete user classes in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes failing deps=high builds in #40403