Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Yaml] Fixed infinite loop when parser goes through an additional and invalid closing tag #40707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2021
Merged

[Yaml] Fixed infinite loop when parser goes through an additional and invalid closing tag #40707

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Yaml] Fixed infinite loop when parser goes through an additional and… 
… invalid closing tag

Instead of letting the parser goes in an infinite loop, throw an exception when the additional and invalid is found
  • Loading branch information
@alexandre-daubois
alexandre-daubois committed Apr 5, 2021
commit d5f8c887a2e7d65312dc4136e2f1343a88883f6b
4 changes: 4 additions & 0 deletions src/Symfony/Component/Yaml/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1225,6 +1225,10 @@ private function lexUnquotedString(int &$cursor): string
$offset = $cursor;
$cursor += strcspn($this->currentLine, '[]{},: ', $cursor);

if ($cursor === $offset) {
throw new ParseException('Malformed unquoted YAML string.');
}

return substr($this->currentLine, $offset, $cursor - $offset);
}

Expand Down
19 changes: 19 additions & 0 deletions src/Symfony/Component/Yaml/Tests/ParserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2676,6 +2676,25 @@ public function testParseValueWithNegativeModifiers()
);
}

public function testThrowExceptionIfInvalidAdditionalClosingTagOccurs()
{
$yaml = '{
"object": {
"array": [
"a",
"b",
"c"
]
],
}
}';

$this->expectException(ParseException::class);
$this->expectExceptionMessage('Malformed unquoted YAML string at line 8 (near " ],").');

$this->parser->parse($yaml);
}

public function testWhitespaceAtEndOfLine()
{
$yaml = "\nfoo:\n arguments: [ '@bar' ] \n";
Expand Down