[Form] Add missing TranslatableMessage support to choice_label option of ChoiceType #40759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
requested changes
Apr 10, 2021
src/Symfony/Component/Form/ChoiceList/Factory/DefaultChoiceListFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/ChoiceList/Factory/DefaultChoiceListFactory.php
Outdated
Show resolved
Hide resolved
|
and yes, I would update the docblock to add TranslatableMessage too. |
0b8df2b to
c13a56d
Compare
|
Thank you so much @yceruto for your advice. I updated the code thanks to your suggestions and edited the PR title as well. |
c13a56d to
c2873aa
Compare
nicolas-grekas
approved these changes
May 7, 2021
|
Thank you @alexandre-daubois. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It leads to loss of information because it'll use
__toStringto cast, which is incompatible with newly addedTranslatableMessage, for example.So this one's a bit tricky in my mind. I didn't want to check if
$dynamicLabel instanceof TranslatableMessage, because of course it doesn't belong to the same component.Aside, it would sound so strange to me to add
|objectto$labelhere:symfony/src/Symfony/Component/Form/ChoiceList/View/ChoiceView.php
Line 40 in bb1e1e5
But maybe that's the way to go? Requiring your help here. I'm fully open to your ideas, as we're loosing a big feature here by losing
TranslatableMessagetranslation parameters.If the passed object doesn't implement
__toString, it'll lead to an exception during template rendering, as expected.