[HttpClient] [PHPDoc] Fix 2 remaining return mixed #40768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Apr 11, 2021
b010961 to
97a43e1
Compare
nicolas-grekas
approved these changes
Apr 11, 2021
|
Thank you @fancyweb. |
|
After merging your changes up to 5.2, the Travis run fails: https://travis-ci.com/github/symfony/symfony/jobs/497617008 Can you have a look, @fancyweb? |
|
Sure I’ll have a look today and revert the return type to a mixed if needed.
…On Mon 12 Apr 2021 at 01:06, Alexander M. Turek ***@***.***> wrote:
After merging your changes up to 5.2, the Travis run fails:
https://travis-ci.com/github/symfony/symfony/jobs/497617008
1) Symfony\Component\HttpClient\Tests\Response\HttplugPromiseTest::testComplexNesting
TypeError: Symfony\Component\HttpClient\Response\HttplugPromise::wait(): Return value must be of type ?Psr\Http\Message\ResponseInterface, string returned
/home/travis/build/symfony/symfony/src/Symfony/Component/HttpClient/Response/HttplugPromise.php:65
/home/travis/build/symfony/symfony/src/Symfony/Component/HttpClient/vendor/guzzlehttp/promises/src/Promise.php:248
/home/travis/build/symfony/symfony/src/Symfony/Component/HttpClient/vendor/guzzlehttp/promises/src/Promise.php:224
/home/travis/build/symfony/symfony/src/Symfony/Component/HttpClient/vendor/guzzlehttp/promises/src/Promise.php:269
/home/travis/build/symfony/symfony/src/Symfony/Component/HttpClient/vendor/guzzlehttp/promises/src/Promise.php:226
/home/travis/build/symfony/symfony/src/Symfony/Component/HttpClient/vendor/guzzlehttp/promises/src/Promise.php:62
/home/travis/build/symfony/symfony/src/Symfony/Component/HttpClient/Response/HttplugPromise.php:59
/home/travis/build/symfony/symfony/src/Symfony/Component/HttpClient/Tests/Response/HttplugPromiseTest.php:34
Can you have a look, @fancyweb <https://github.com/fancyweb>?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40768 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA35DB2PXG4O24HIDPJ2ITTTIITOHANCNFSM42XYV7RQ>
.
|
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Apr 12, 2021
|
Reverted in #40775 |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 12, 2021
…ng return mixed (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] Revert "minor #40768 [PHPDoc] Fix 2 remaining return mixed | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This reverts commit 40d7315, reversing changes made to 4e904ec. As spotted by the CI and reported in #40768 (comment) Using `Psr7ResponseInterface|mixed` instead of just `mixed` provides a better DX, by making autocompletion more useful. Commits ------- afea0a0 Revert "minor #40768 [HttpClient] [PHPDoc] Fix 2 remaining return mixed (fancyweb)"
nicolas-grekas
added a commit
that referenced
this pull request
Apr 12, 2021
* 4.4: [HttpKernel] Minor fixes and tweaks in the Symfony Welcome Page Revert "minor #40768 [HttpClient] [PHPDoc] Fix 2 remaining return mixed (fancyweb)"
nicolas-grekas
added a commit
that referenced
this pull request
Apr 12, 2021
* 5.2: [HttpKernel] Minor fixes and tweaks in the Symfony Welcome Page Revert "minor #40768 [HttpClient] [PHPDoc] Fix 2 remaining return mixed (fancyweb)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two cases I forgot in #40728 😕