Fix/Implement recursive Finder::ignoreVCSIgnored filter #40769
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mvorisek
commented
Apr 11, 2021
•
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #37781 |
| License | MIT |
| Doc PR | no |
6fa953b to
884af41
Compare
|
Hey! I think @hurricane-voronin has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
f1862d0 to
8a5de63
Compare
|
It can be seen as a bug fix, but this is a new feature according to the way we think about versionning. So, this must target 5.4 instead of 4.4. Thank you. |
|
#43150 provided this functionality, I will submit another PR to add the relativize method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.