Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Intl] Switch from json to php resources #40790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Apr 12, 2021

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #23545
License MIT
Doc PR -

take over #34214

@nicolas-grekas
Copy link
Member

In PhpBundleReader, I think we should remove the file_exists() check and keep only the is_file() one, for perf.

👍 otherwise

@ro0NL
Copy link
Contributor

ro0NL commented Apr 13, 2021

do we fancy cleaning up other readers/writers while at it? e.g.TextBundleWriter only receives cs fixes as of 2014 :}

@jderusse jderusse force-pushed the intl-php branch 6 times, most recently from 01c6bae to c929746 Compare April 13, 2021 12:43
@jderusse
Copy link
Member Author

RFR
Version bumped to 69.1,
Optimization suggested by @nicolas-grekas applied
tested fixed

@nicolas-grekas
Copy link
Member

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit 501c310 into symfony:5.x Apr 14, 2021
@jderusse jderusse deleted the intl-php branch April 16, 2021 17:44
@bastnic
Copy link
Contributor

bastnic commented Jun 11, 2021

FYI, on symfony demo app:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants