[PropertyInfo] Use the right context for methods defined in traits#40811
Merged
Conversation
dunglas
approved these changes
Apr 13, 2021
chalasr
approved these changes
Apr 14, 2021
Member
|
The target branch should be 4.4. |
Member
|
Thank you @colinodell. |
Zales0123
added a commit
to Sylius/Sylius
that referenced
this pull request
May 12, 2021
…ith wrong namespaces of some translation entities (GSadee) This PR was merged into the 1.9 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.9 | Bug fix? | yes | New feature? | no/ | BC breaks? | no | Deprecations? | no | Related tickets | probably introduced in symfony/symfony#40811 | License | MIT The problem occurs in Swagger UI docs and there is a problem with resolving proper namespaces during serializing translation entities, e.g.:  Commits ------- dc01355 [API] Conflict with symfony/property-info due to problem with wrong namespaces of some translation entities
SirDomin
pushed a commit
to SirDomin/Sylius
that referenced
this pull request
Jul 7, 2021
…blem with wrong namespaces of some translation entities (GSadee) This PR was merged into the 1.9 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.9 | Bug fix? | yes | New feature? | no/ | BC breaks? | no | Deprecations? | no | Related tickets | probably introduced in symfony/symfony#40811 | License | MIT The problem occurs in Swagger UI docs and there is a problem with resolving proper namespaces during serializing translation entities, e.g.:  Commits ------- dc01355 [API] Conflict with symfony/property-info due to problem with wrong namespaces of some translation entities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request #40175 only partially fixed #34191 - it solved the problem for properties used in traits but it did not address the same issue with methods.
I have therefore applied the same style of fix and confirmed it works properly with tests.