-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Config] [ConfigBuilder] Set FQCN as properties type instead of class name #40956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MatTheCat
commented
Apr 27, 2021
Q | A |
---|---|
Branch? | 5.x |
Bug fix? | yes |
New feature? | no |
Deprecations? | no |
Tickets | Fix #40921 |
License | MIT |
Doc PR | N/A |
Oh, yes. The constructors! Could you add a small tests for this too? Have a look at |
Well thank you for the ConfigBuilder 😁 Could I just replace symfony/src/Symfony/Component/Config/Tests/Builder/Fixtures/AddToList.config.php Lines 10 to 13 in 63496df
$config->messenger([
'routing' => [
'Foo\\Message' => [
'senders' => ['workqueue'],
],
'Foo\\DoubleMessage' => [
'senders' => ['sync', 'workqueue'],
],
]
]); ? |
Sure, but dont replace anything. Just add a third message.
|
Done 👌 Travis failure seems unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great. Thank you
7376189
to
e9aa1c5
Compare
Thanks for fixing this bug Mathieu. |