[Config] More accurate message on invalid config builder #40994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
reviewed
Apr 30, 2021
| } | ||
|
|
||
| // Try to get the extension alias | ||
| $alias = Container::underscore(substr($namespace, 15, -6)); | ||
|
|
||
| if (false !== strpos($alias, '\\')) { | ||
| throw new InvalidArgumentException(sprintf('Nested bundle config class "%s" could not be handled.', $namespace)); |
There was a problem hiding this comment.
Technically, we are not talking about "bundles" but "extensions".
Could we be more descriptive here?
Something more similar to this?
Could not find or generate class "%s". Make sure to use the "root" ConfigBuilder class. Ie use "Symfony\Config\FrameworkConfig" and not Symfony\Config\Framework\CacheConfig"
There was a problem hiding this comment.
I have tried to make message more descriptive, but without concrete classes.
There was a problem hiding this comment.
Oh. I missed this comment.
I do agree that not using Symfony\Config\Framework\CacheConfig may be better, but it is also very hard to understand what "nested classes" really mean. Im not sure that my suggestion is the best.
src/Symfony/Component/DependencyInjection/Tests/Loader/PhpFileLoaderTest.php
Outdated
Show resolved
Hide resolved
1c3b4d7 to
5ece904
Compare
Nyholm
reviewed
Apr 30, 2021
src/Symfony/Component/DependencyInjection/Tests/Loader/PhpFileLoaderTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Loader/PhpFileLoader.php
Outdated
Show resolved
Hide resolved
Throw exception when try to autowire nested bundle config instead of ConfigBuilder. Also renamed test class AcmeConfigBuilder to AcmeConfig according config builders auto naming.
5ece904 to
0501ecc
Compare
Nyholm
approved these changes
Apr 30, 2021
src/Symfony/Component/DependencyInjection/Tests/Fixtures/config/nested_bundle_config.php
Show resolved
Hide resolved
nicolas-grekas
approved these changes
May 2, 2021
|
Thank you @a-menshchikov. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throw exception when trying to autowire nested bundle config instead of ConfigBuilder (related Doc PR symfony/symfony-docs#15300).
Also renamed test class AcmeConfigBuilder to AcmeConfig according config builders auto naming.
Inspired by a chat with @Nyholm