Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Form] Use reference date in reverse transform #40998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2022
Merged

[Form] Use reference date in reverse transform #40998

merged 1 commit into from
Apr 12, 2022

Conversation

KDederichs
Copy link
Contributor

@KDederichs KDederichs commented Apr 30, 2021 •
edited by nicolas-grekas
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40997
License MIT

Use reference time in reverse transform to fix the display inconsistancies

@carsonbot carsonbot added this to the 5.2 milestone Apr 30, 2021
@xabbuh
Copy link
Member

xabbuh commented Apr 30, 2021

Can you add a test case that would fail without this patch?

@KDederichs
Copy link
Contributor Author

Can you add a test case that would fail without this patch?

Let me see if I can make a good one

@KDederichs
Copy link
Contributor Author

hmmm, maybe it's more of an issue of if should be a valid setting for that input anyways (maybe help me out with thinking here).
Does the timezone need to be applied to an array field that only stores hours and minutes in the first place? The more I think about it the answer is: probably not.
Cause tbh it's a bit of strange and undefined behaviour which probably also relates to the other thing I ran into:
#41000

Maybe it would me more sense to disable the model and view timezone options for the array input all together and throw a logic exception when you try it?

@KDederichs KDederichs mentioned this pull request May 7, 2021
Closed
@carsonbot carsonbot changed the title Use reference date in reverse transform [Form] Use reference date in reverse transform May 7, 2021
@xabbuh
Copy link
Member

xabbuh commented May 17, 2021

Does this apply to 4.4 too?

@KDederichs
Copy link
Contributor Author

Yes, this changed line is present in 4.4 as well

@derrabus derrabus modified the milestones: 5.2, 4.4 May 17, 2021
@xabbuh xabbuh changed the base branch from 5.2 to 4.4 April 12, 2022 13:13
@nicolas-grekas
Copy link
Member

Thank you @KDederichs.

@nicolas-grekas nicolas-grekas merged commit 639b74d into symfony:4.4 Apr 12, 2022
This was referenced Apr 27, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@xabbuh xabbuh xabbuh approved these changes

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

@lyrixx lyrixx Awaiting requested review from lyrixx

@dunglas dunglas Awaiting requested review from dunglas

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr

@jderusse jderusse Awaiting requested review from jderusse

Assignees
No one assigned
Labels
Bug Form Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@KDederichs @xabbuh @nicolas-grekas @derrabus @carsonbot