Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle][HttpKernel] Move IDE file link formats from FrameworkExtension to FileLinkFormatter #41002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2021
Merged

[FrameworkBundle][HttpKernel] Move IDE file link formats from FrameworkExtension to FileLinkFormatter #41002

merged 1 commit into from
May 1, 2021

Conversation

MatTheCat
Copy link
Contributor

@MatTheCat MatTheCat commented Apr 30, 2021 •
edited
Loading

Q A
Branch? 5.x
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #40901
License MIT
Doc PR N/A

I made FileLinkFormatter aware of IDEs file link formats so that you can set framework.ide as an env var containing a name (like atom).

Not sure how to test it from the FrameworkExtension POV though 🤔

@carsonbot carsonbot added this to the 4.4 milestone Apr 30, 2021
@carsonbot carsonbot changed the title [FrameworkBundle][Debug] Move IDE file link formats from FrameworkExtension to FileLinkFormatter [Debug][FrameworkBundle] Move IDE file link formats from FrameworkExtension to FileLinkFormatter Apr 30, 2021
nicolas-grekas
nicolas-grekas reviewed Apr 30, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.
That's an improvement, thus for 5.x

@MatTheCat MatTheCat changed the base branch from 4.4 to 5.x April 30, 2021 13:26
@MatTheCat MatTheCat force-pushed the ticket_40901 branch 2 times, most recently from 7d937c3 to 58ff1bd Compare April 30, 2021 13:29
@MatTheCat
Copy link
Contributor Author

MatTheCat commented Apr 30, 2021 •
edited
Loading

@nicolas-grekas I applied your suggestions on the 5.x branch where the templating.helper.code.file_link_format parameter no longer exists.

@nicolas-grekas nicolas-grekas modified the milestones: 4.4, 5.x Apr 30, 2021
@carsonbot carsonbot changed the title [Debug][FrameworkBundle] Move IDE file link formats from FrameworkExtension to FileLinkFormatter [FrameworkBundle][HttpKernel] Move IDE file link formats from FrameworkExtension to FileLinkFormatter Apr 30, 2021
@MatTheCat
Copy link
Contributor Author

I take it from the approval I don’t have to add a case to FrameworkExtensionTest? 😁

@fabpot
Copy link
Member

fabpot commented May 1, 2021

Thank you @MatTheCat.

@fabpot fabpot mentioned this pull request May 1, 2021
Closed
@fabpot fabpot merged commit 942847f into symfony:5.x May 1, 2021
@fabpot fabpot mentioned this pull request May 1, 2021
Merged
@MatTheCat MatTheCat deleted the ticket_40901 branch May 1, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@lyrixx lyrixx Awaiting requested review from lyrixx

@wouterj wouterj Awaiting requested review from wouterj

@xabbuh xabbuh Awaiting requested review from xabbuh

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
FrameworkBundle HttpKernel Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

framework.ide does not resolve known link format when using env()
5 participants
@MatTheCat @fabpot @nicolas-grekas @stof @carsonbot