Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FrameworkBundle] fix ConfigBuilderCacheWarmer #41458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2021
Merged

[FrameworkBundle] fix ConfigBuilderCacheWarmer #41458

merged 1 commit into from
May 31, 2021

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

@carsonbot carsonbot changed the title [FrameworkBundle] fix ConfigBuilderCacheWarmer fix ConfigBuilderCacheWarmer May 31, 2021
@nicolas-grekas nicolas-grekas mentioned this pull request May 31, 2021
Closed
Nyholm
Nyholm approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thank you

@carsonbot carsonbot changed the title fix ConfigBuilderCacheWarmer [FrameworkBundle] fix ConfigBuilderCacheWarmer May 31, 2021
@Nyholm
Copy link
Member

Nyholm commented May 31, 2021

This psalm error might have been the reason I didnt do this in the first place.

@nicolas-grekas nicolas-grekas added this to the 5.3 milestone May 31, 2021
@fabpot
Copy link
Member

fabpot commented May 31, 2021

Thank you @nicolas-grekas.

@fabpot fabpot merged commit e008263 into symfony:5.3 May 31, 2021
@fabpot fabpot mentioned this pull request May 31, 2021
Merged
@nicolas-grekas nicolas-grekas deleted the fix-config-warmer branch June 3, 2021 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @Nyholm @fabpot @carsonbot