Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Hi, thanks for the PR!
Could you please add a test case and squash the commits?

Hi, thanks for the PR!
Could you please add a test case and squash the commits?

sure, could you please give me a hint where i can find tests for Symfony\Component\HttpFoundation\Session\Storage\Handler\SessionHandlerFactory so i could simple extend them ?

haven't found them here...
https://github.com/symfony/symfony/tree/4.4/src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Handler

It looks like there are no tests for it yet. That's a good opportunity to add some :)

@nicolas-grekas added a test and everything seems "green". :-)

There still exist issues with other components using traits that doesn't exist anymore... but i think we could ignore this concerning this PR ?

Thank you @simonchrz.