Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Validator] Fix typos in EL translation #41711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

simplegr
Copy link
Contributor

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
License MIT

Fixing some typos

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title Fix typos [Validator] Fix typos Jun 15, 2021
@derrabus derrabus changed the title [Validator] Fix typos [Validator] Fix typos in EL translation Jun 15, 2021
@derrabus derrabus added this to the 4.4 milestone Jun 15, 2021
@derrabus derrabus requested a review from Nyholm June 15, 2021 15:35
@derrabus
Copy link
Member

Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)

Can you please rebase your PR onto the 4.4 branch?

@simplegr
Copy link
Contributor Author

Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)

Can you please rebase your PR onto the 4.4 branch?

Sorry my mistake. I did a PR for 4.4 branch. Should I delete this one?

@Nyholm
Copy link
Member

Nyholm commented Jun 15, 2021

There is no need to close this PR. You can just edit the PR target branch and do a rebase if needed.

@derrabus
Copy link
Member

Oh, I didn't see that there is already #41712. We can close this one, yes.

@derrabus derrabus closed this Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants