Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Avoid broken action URL in text notification mail #41739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Conversation

mbrodala
Copy link
Contributor

Q A
Branch? 5.3 for bug fixes
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

Some mail clients make URLs clickable automatically which leads to broken URLs due to the appended ":" (colon)

Fix this by moving the action text before the action URL.

@carsonbot carsonbot added this to the 5.3 milestone Jun 18, 2021
@mbrodala mbrodala changed the title Avoid broken action URL in text notification mail [TwigBridge] Avoid broken action URL in text notification mail Jun 18, 2021
@carsonbot carsonbot changed the title [TwigBridge] Avoid broken action URL in text notification mail Avoid broken action URL in text notification mail Jun 23, 2021
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for 5.2

Some mail clients make URLs clickable automatically which leads to broken URLs due to the appended ":" (colon)

Fix this by moving the action text before the action URL.
@fabpot
Copy link
Member

fabpot commented Jun 23, 2021

Thank you @mbrodala.

@fabpot fabpot merged commit e1b81e3 into symfony:5.2 Jun 23, 2021
@mbrodala mbrodala deleted the patch-2 branch June 23, 2021 09:44
This was referenced Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants