Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Psalm is failing because the class Phake\IMock doesn't exists. I could add phake/phake to the require-dev but not sure if this is really a good idea since it's not used anywhere else.

Psalm is failing because the class Phake\IMock doesn't exists. I could add phake/phake to the require-dev but not sure if this is really a good idea since it's not used anywhere else.

not needed. We use the existing codebase as a psalm baseline, so this won't bother next changes

Thank you @adoy.