Fixing Doc blocks should be done as a bugfix on lower branches (4.4 mainly, in this case).

Fixing Doc blocks should be done as a bugfix on lower branches (4.4 mainly, in this case).

I fully agree on this.
But on one of my last PR there was this debate #40604 and it ended with the decision it should be on 5.x.

If the core team now decide it's a bugfix, I'm fine doing it on 4.4 but I'd like some confirmation before doing this PR again.

Fair enough. Sorry for the confusion. 😞

We try to remove phpdoc actually.
We have a rule where the default type of a property is enough clue to tell its type.
I'm fine adding phpdoc when it really brings value, but I'd better remove them otherwise.

We have a rule where the default type of a property is enough clue to tell its type.
I'm fine adding phpdoc when it really brings value, but I'd better remove them otherwise.

The rule has some sens, but it's not because a property has a default value that another type is forbidden
For instance
https://github.com/symfony/symfony/pull/42136/files#diff-738b9954d83ec3560d6a0b70f45958640c89abd268d72bba647e87c0ff13e185R50
The default value is an array, but looking at the code, a string is allowed too.

My main issue was that psalm and phpstan consider as mixed every property without typehint or phpdoc. Witch is pretty annoying when overriding a constraint class/property and adding some phpdoc. I would have prefer to add the phpdoc here rather than in the stub of psalm-symfony repository. The phpdoc can be removed in 6.0 when the type will be added.

That's an issue with psalm/phpstan, it might be fixed with a plugin maybe?
But I'm overall 👎 to "pollute" the code base with useless phpdoc, we already spend too much time on maintaining these.

That's an issue with psalm/phpstan, it might be fixed with a plugin maybe?
But I'm overall 👎 to "pollute" the code base with useless phpdoc, we already spend too much time on maintaining these.

So I should remove the phpdoc of property with default value and keep the others ?

So I should remove the phpdoc of property with default value and keep the others ?

That'd work for me yes. If a default value can be added instead in some cases, that'd be even better.