[Messenger] [Redis] Fix auth option wrongly considered invalid #42173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
commented
Jul 18, 2021
|
|
||
| Connection::fromDsn('redis://password:localhost/queue', [], $redis); | ||
| } | ||
|
|
There was a problem hiding this comment.
This test was added in #42067 but it never passed, the dsn is invalid (https://github.com/symfony/symfony/runs/3097443193#step:11:102)
27a3f5a to
ccc5513
Compare
chalasr
commented
Jul 18, 2021
| /** | ||
| * @group legacy | ||
| * ^ for now, deprecation errors are thrown during serialization. | ||
| */ |
There was a problem hiding this comment.
This test was broken because it uses an incomplete symfony serializer (see https://github.com/symfony/symfony/runs/3097443193#step:11:72)
|
Green 🎉 |
Nyholm
reviewed
Jul 18, 2021
src/Symfony/Component/Messenger/Bridge/Redis/Tests/Transport/ConnectionTest.php
Show resolved
Hide resolved
| @@ -225,6 +225,7 @@ private static function validateOptions(array $options): void | |||
| { | |||
| $availableOptions = array_keys(self::DEFAULT_OPTIONS); | |||
| $availableOptions[] = 'serializer'; | |||
| $availableOptions[] = 'auth'; | |||
There was a problem hiding this comment.
Because these options did not have a default and if they aren't added to the $avaibleOptions array, you get a deprecation notice (exception in 6.0).
It turns out that we can easily add ones, I did :)
5df784c to
95c5558
Compare
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will also make the CI back to green on 5.2.