Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[HttpKernel] always close open stopwatch section after handling kernel.request events #42331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 30, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #36623
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.4 milestone Jul 30, 2021
@carsonbot carsonbot changed the title [HttpKernel] always close open stopwatch section after handling kernel.request events [HttpKernel]  always close open stopwatch section after handling kernel.request events Jul 30, 2021
@OskarStark OskarStark changed the title [HttpKernel]  always close open stopwatch section after handling kernel.request events [HttpKernel] always close open stopwatch section after handling kernel.request events Aug 1, 2021
@OskarStark OskarStark changed the title [HttpKernel] always close open stopwatch section after handling kernel.request events [HttpKernel] always close open stopwatch section after handling kernel.request events Aug 1, 2021
@fabpot
Copy link
Member

fabpot commented Aug 6, 2021

Thank you @xabbuh.

@fabpot fabpot merged commit f2f96a0 into symfony:4.4 Aug 6, 2021
@xabbuh xabbuh deleted the issue-36623 branch August 6, 2021 10:41
This was referenced Aug 30, 2021
herndlm added a commit to herndlm/symfony that referenced this pull request Sep 1, 2021
In order for the TimeDataCollector to work properly the X-Debug-Token from the response header needs to be used which was removed in symfony#42331 to fix symfony#36623. Fixes symfony#42804
herndlm added a commit to herndlm/symfony that referenced this pull request Sep 1, 2021
In order for the `TimeDataCollector` to work properly the `X-Debug-Token` from the response header needs to be used which was removed in symfony#42331 to fix symfony#36623. Fixes symfony#42804
fabpot added a commit that referenced this pull request Sep 1, 2021
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] Fix empty timeline in profiler

Simple fix to #42804

| Q             | A
| ------------- | ---
| Branch?       | 5.3 && 4.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #42804 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT

Fix #42804 following #42331 conventions

Another solution could be found here #42823

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/releases):
 - Always add tests and ensure they pass.
 - Never break backward compatibility (see https://symfony.com/bc).
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too.)
 - Features and deprecations must be submitted against branch 5.x.
 - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
-->

Commits
-------

f1b3840 [HttpKernel] Fix timeline in profiler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants