Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Cache] Do not add namespace argument to NullAdapter in CachePoolPass #42365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2021
Merged

[Cache] Do not add namespace argument to NullAdapter in CachePoolPass #42365

merged 1 commit into from
Aug 6, 2021

Conversation

olsavmic
Copy link
Contributor

@olsavmic olsavmic commented Aug 4, 2021 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #42364.
License MIT

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@olsavmic olsavmic force-pushed the fix-cache-pool-pass-for-null-adapter branch from ad4e825 to 5eb1e56 Compare August 4, 2021 08:55
@olsavmic olsavmic changed the base branch from 5.4 to 5.3 August 4, 2021 08:55
@olsavmic olsavmic changed the base branch from 5.3 to 5.4 August 4, 2021 08:55
@olsavmic olsavmic force-pushed the fix-cache-pool-pass-for-null-adapter branch from 5eb1e56 to 3cbbef7 Compare August 4, 2021 08:57
@olsavmic olsavmic changed the base branch from 5.4 to 5.3 August 4, 2021 08:57
@olsavmic olsavmic force-pushed the fix-cache-pool-pass-for-null-adapter branch from 3cbbef7 to e542b71 Compare August 4, 2021 08:58
@chalasr chalasr modified the milestones: 5.3, 5.2 Aug 4, 2021
@derrabus
Copy link
Member

derrabus commented Aug 4, 2021

The linked ticket says that the issue is present on 4.4 already. Should we rebase the PR to 4.4 then?

@carsonbot carsonbot changed the title Do not add namespace argument to NullAdapter in CachePoolPass [Cache] Do not add namespace argument to NullAdapter in CachePoolPass Aug 4, 2021
@OskarStark OskarStark changed the title [Cache] Do not add namespace argument to NullAdapter in CachePoolPass [Cache] Do not add namespace argument to NullAdapter in CachePoolPass Aug 4, 2021
@olsavmic olsavmic force-pushed the fix-cache-pool-pass-for-null-adapter branch from e542b71 to 2f742bc Compare August 6, 2021 10:35
@olsavmic olsavmic changed the base branch from 5.3 to 4.4 August 6, 2021 10:35
@olsavmic
Copy link
Contributor Author

olsavmic commented Aug 6, 2021

The linked ticket says that the issue is present on 4.4 already. Should we rebase the PR to 4.4 then?

Correct, rebased to 4.4

@OskarStark OskarStark modified the milestones: 5.3, 4.4 Aug 6, 2021
@Tobion
Copy link
Contributor

Tobion commented Aug 6, 2021

Thanks for the well done PR @olsavmic

@Tobion Tobion merged commit 4f2987d into symfony:4.4 Aug 6, 2021
This was referenced Aug 30, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobion Tobion Tobion approved these changes

@derrabus derrabus derrabus approved these changes

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@lyrixx lyrixx Awaiting requested review from lyrixx

@OskarStark OskarStark Awaiting requested review from OskarStark

@sroze sroze Awaiting requested review from sroze

@wouterj wouterj Awaiting requested review from wouterj

@xabbuh xabbuh Awaiting requested review from xabbuh

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
Bug Cache Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

[Cache] NullAdapter configuration in framework - Cannot replace arguments if none have been configured yet
6 participants
@olsavmic @carsonbot @derrabus @Tobion @OskarStark @chalasr