[PropertyInfo] Support for the never return type
#42628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander M. Turek <[email protected]>
28662cd to
091769a
Compare
never return type
dunglas
approved these changes
Aug 18, 2021
jderusse
approved these changes
Aug 19, 2021
| @@ -233,7 +233,7 @@ public function php71TypesProvider() | |||
| } | |||
|
|
|||
| /** | |||
| * * @dataProvider php80TypesProvider | |||
There was a problem hiding this comment.
should be fixed upstream? right?
There was a problem hiding this comment.
I think it's fine to fix it in this PR. I'm targeting our lowest branch already.
carlcasbolt
approved these changes
Aug 19, 2021
OskarStark
approved these changes
Aug 19, 2021
chalasr
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the PropertyInfo component encounters the new
neverreturn type, it currently exits with an exception that isn't helpful. This PR proposes to skip that type because we cannot extract type information from it.