[Translation] Fix message key handling for the Localise provider #42649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the bugfix, can you please add a testcase to avoid further regressions? cc @welcoMattic |
welcoMattic
approved these changes
Aug 20, 2021
MikeDevresse
approved these changes
Aug 20, 2021
|
Done |
|
@welcoMattic can you please review/test again? Thanks |
|
Since the PR title will appear in the ChangeLog of the next release: Can we please find a better one? The current title does not tell me what aspect of the provider needs fixing. |
|
How can I help you? |
fabpot
approved these changes
Aug 23, 2021
|
Thank you @xepozz. |
fabpot
added a commit
that referenced
this pull request
Aug 23, 2021
…ovider (xepozz) This PR was squashed before being merged into the 5.3 branch. Discussion ---------- [Translation] Fix message key handling for the Localise provider | Q | A | ------------- | --- | Branch? | 5.3 and above | Bug fix? | yes | New feature? |no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? |no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | - Fixed non-recursively merging existing keys and created. Now created keys totally removed by usual merge. Handled situation when no keys are created in localise service. Commits ------- 36b4837 [Translation] Fix message key handling for the Localise provider
aee469a to
36b4837
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed non-recursively merging existing keys and created. Now created keys totally removed by usual merge.
Handled situation when no keys are created in localise service.