[Notifier] Firebase error handling #42690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so the transports doesn't try setting the success message, that doesn't exists.
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
OskarStark
approved these changes
Aug 23, 2021
fabpot
approved these changes
Aug 23, 2021
|
Thank you @mishaklomp. |
Merged
This was referenced Oct 12, 2021
fabpot
added a commit
that referenced
this pull request
Oct 12, 2021
…sport (villfa) This PR was merged into the 5.3 branch. Discussion ---------- [Notifier] Fix 'Undefined array key' error in FirebaseTransport | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #42841 | License | MIT | Doc PR | n/a This modification fixes a remaining `Undefined array key` error in *FirebaseTransport*. It also add a test to cover #42690. <!-- Replace this notice by a short README for your feature/bugfix. This will help people understand your PR and can be used as a start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - Never break backward compatibility (see https://symfony.com/bc). - Bug fixes must be submitted against the lowest maintained branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too.) - Features and deprecations must be submitted against branch 5.x. - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry --> Commits ------- 53f836e [Notifier] Fix 'Undefined array key' error in FirebaseTransport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug in the Firebase error handling, resulting in a
Undefined index: message_iderror.It occurred when trying to send a notification to an unregistered device token. As I stated in my issue before.
Don't know if this (little) change should include any tests?
This is my first PR, so any feedback is welcome!