[CI] Ensure that all possible @return are turned into native types
#42735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d32b12e to
25172d7
Compare
stof
reviewed
Aug 25, 2021
| - sed -i 's/ *"\*\*\/Tests\/"//' composer.json | ||
| - composer u -o | ||
| - SYMFONY_PATCH_TYPE_DECLARATIONS='force=2' php .github/patch-types.php | ||
| - git diff -U2 composer.json src/ >.github/expected-missing-return-types.diff |
There was a problem hiding this comment.
wouldn't this remove those instructions ?
There was a problem hiding this comment.
that's right, we'll catch this by reviews I guess :)
25172d7 to
2b5cd7a
Compare
This was referenced Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the final step to close the topic of return types for Symfony 6.
It replaces #42496 by not adding return types to the classes/interfaces that break cross-component deps.
It enforces that all
@returnfrom 5.4 are turned into native types in 6.0, with the known list of exceptions from #42496.