[Messenger] Fix broken Redis mocks #43029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
505631b to
d9a4d1d
Compare
|
Apparently, SetupPHP installs some dev snapshot of |
|
I've pinned the redis extension to get green tests again. |
chalasr
approved these changes
Sep 14, 2021
derrabus
added a commit
that referenced
this pull request
Sep 14, 2021
This PR was merged into the 4.4 branch. Discussion ---------- Pin ext-redis version in CI | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Backport from #43029 | License | MIT | Doc PR | N/A Commits ------- ca34753 Pin ext-redis version in CI
cb98d1a to
df36e0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, the PHP 8.1 CI runs a dev snapshot of ext-redis that has return types. This breaks some of our mock configurations.