[Messenger] Add worker metadata inside logs #43355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyrixx
approved these changes
Oct 7, 2021
chalasr
approved these changes
Oct 7, 2021
fabpot
reviewed
Oct 7, 2021
| @@ -31,7 +31,7 @@ public function onWorkerStarted(WorkerStartedEvent $event): void | |||
| { | |||
| pcntl_signal(\SIGTERM, function () use ($event) { | |||
| if (null !== $this->logger) { | |||
| $this->logger->info('Received SIGTERM signal.'); | |||
| $this->logger->info('Received SIGTERM signal.', ['transportNames' => $event->getWorker()->getMetadata()->getTransportNames()]); | |||
There was a problem hiding this comment.
I think we are using underscore names in such a situation, so transport_names.
There was a problem hiding this comment.
@fabpot in fact, I've found both cases camelCase|snake_case in the codebase
I'll rework this but maybe it is needed a consensus here :)
6d6eca4 to
649cb10
Compare
fabpot
approved these changes
Oct 7, 2021
|
Thank you @94noni. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR related to one of my comment #42723 (comment) on the ticket PR: having this contextual info is valuable imho
cc @ruudk @okwinza @fabpot