Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Console] Show proxified command class in completion debug #43661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2021
Merged

[Console] Show proxified command class in completion debug #43661

merged 1 commit into from
Oct 22, 2021

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Oct 22, 2021 •
edited
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Fix the class shown in completion debug when the command is wrapped in LazyCommand.

Before:

Input: ("|" indicates the cursor position)
  bin/console debug:form|
Messages:
  Completing using the Symfony\Component\Console\Command\LazyCommand class.
  Completing argument_value for class
  Current value: 
Suggestions:

After:

Input: ("|" indicates the cursor position)
  bin/console debug:form|
Messages:
  Completing using the Symfony\Component\Form\Command\DebugCommand class.
  Completing argument_value for command
  Current value: debug:form
Suggestions:

@GromNaN GromNaN requested a review from chalasr as a code owner October 22, 2021 16:21
@carsonbot carsonbot added this to the 5.4 milestone Oct 22, 2021
@GromNaN GromNaN changed the title [Console] Add show proxified command class in completion debug [Console] Show proxified command class in completion debug Oct 22, 2021
chalasr
chalasr approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@fabpot
Copy link
Member

fabpot commented Oct 22, 2021

Thank you @GromNaN.

@fabpot fabpot merged commit ff70bd1 into symfony:5.4 Oct 22, 2021
@GromNaN GromNaN deleted the console/5.4-complete-lazy branch October 22, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Console Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@GromNaN @fabpot @chalasr @carsonbot