[Runtime] Consider also $_ENV when resolving APP_RUNTIME and APP_RUNTIME_OPTIONS #43833
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
CHANGELOG-5.3.md
Outdated
| @@ -552,4 +552,4 @@ To get the diff between two versions, go to https://github.com/symfony/symfony/c | |||
| * feature #38596 [BrowserKit] Add jsonRequest function to the browser-kit client (alexander-schranz) | |||
| * feature #38998 [Messenger][SQS] Make sure one can enable debug logs (Nyholm) | |||
| * feature #38974 [Intl] deprecate polyfills in favor of symfony/polyfill-intl-icu (nicolas-grekas) | |||
|
|
|||
| * feature #43832 [Runtime] consider also $_ENV when resolving APP_RUNTIME and APP_RUNTIME_OPTIONS (peter-si) | |||
There was a problem hiding this comment.
please remove this line: this file is autogenerated
There was a problem hiding this comment.
Oh ok. Might I suggest to change the PR template? Since it says | New feature? | yes/no <!-- please update src/**/CHANGELOG.md files -->
There was a problem hiding this comment.
the file you changed is not under src/ ;)
that's fine, it's your first contribution, we're here to help :)
There was a problem hiding this comment.
true that...It got me confused :) Thanks, it is reverted.
|
Thank you @peter-si. |
Take also $_ENV into consideration when resolving APP_RUNTIME and APP_RUNTIME_OPTIONS.
On docker apache containers to get env variable into $_SERVER other configuration steps are needed. This is unnecessary since they are already available in $_ENV. Or maybe we can use getenv()? I'm preparing a PR for it (will be done in a bit)