Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Inflector] Fix inflector for "zombies" #43834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

acodispo
Copy link
Contributor

The word "zombies" should be singularized to "zombie" (rather than
"zomby"). We provide a PLURAL_MAP for this case, as well as a test.

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets See #43789
License MIT

@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

The word "zombies" should be singularized to "zombie" (rather than
"zomby"). We provide a PLURAL_MAP for this case, as well as a test.
@fabpot
Copy link
Member

fabpot commented Oct 29, 2021

Thank you @acodispo.

@fabpot fabpot merged commit a9b5383 into symfony:4.4 Oct 29, 2021
@wkania
Copy link
Contributor

wkania commented Oct 30, 2021

@fabpot This apparently caused PHP 8 CI to fail on branch 5.4

@derrabus
Copy link
Member

@wkania see #43842

@acodispo acodispo deleted the ticket_43789_symf4 branch October 30, 2021 20:35
This was referenced Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants