-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[DoctrineBridge] Add an Entity Argument Resolver #43854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,246 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <[email protected]> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Bridge\Doctrine\ArgumentResolver; | ||
|
||
use Doctrine\DBAL\Types\ConversionException; | ||
use Doctrine\ORM\EntityManagerInterface; | ||
use Doctrine\ORM\NoResultException; | ||
use Doctrine\Persistence\ManagerRegistry; | ||
use Doctrine\Persistence\ObjectManager; | ||
use Symfony\Bridge\Doctrine\Attribute\MapEntity; | ||
use Symfony\Component\ExpressionLanguage\ExpressionLanguage; | ||
use Symfony\Component\HttpFoundation\Request; | ||
use Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface; | ||
use Symfony\Component\HttpKernel\ControllerMetadata\ArgumentMetadata; | ||
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException; | ||
|
||
/** | ||
* Yields the entity matching the criteria provided in the route. | ||
* | ||
* @author Fabien Potencier <[email protected]> | ||
* @author Jérémy Derussé <[email protected]> | ||
*/ | ||
final class EntityValueResolver implements ArgumentValueResolverInterface | ||
{ | ||
public function __construct( | ||
private ManagerRegistry $registry, | ||
private ?ExpressionLanguage $expressionLanguage = null, | ||
private MapEntity $defaults = new MapEntity(), | ||
) { | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function supports(Request $request, ArgumentMetadata $argument): bool | ||
{ | ||
if (!$this->registry->getManagerNames()) { | ||
return false; | ||
} | ||
|
||
$options = $this->getOptions($argument); | ||
if (!$options->class || $options->disabled) { | ||
return false; | ||
} | ||
|
||
// Doctrine Entity? | ||
if (!$objectManager = $this->getManager($options->objectManager, $options->class)) { | ||
return false; | ||
} | ||
|
||
return !$objectManager->getMetadataFactory()->isTransient($options->class); | ||
} | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
public function resolve(Request $request, ArgumentMetadata $argument): iterable | ||
{ | ||
$options = $this->getOptions($argument); | ||
$name = $argument->getName(); | ||
$class = $options->class; | ||
|
||
$errorMessage = null; | ||
if (null !== $options->expr) { | ||
if (null === $object = $this->findViaExpression($class, $request, $options->expr, $options)) { | ||
$errorMessage = sprintf('The expression "%s" returned null', $options->expr); | ||
} | ||
// find by identifier? | ||
} elseif (false === $object = $this->find($class, $request, $options, $name)) { | ||
// find by criteria | ||
if (false === $object = $this->findOneBy($class, $request, $options)) { | ||
if (!$argument->isNullable()) { | ||
throw new \LogicException(sprintf('Unable to guess how to get a Doctrine instance from the request information for parameter "%s".', $name)); | ||
} | ||
|
||
$object = null; | ||
} | ||
} | ||
|
||
if (null === $object && !$argument->isNullable()) { | ||
$message = sprintf('"%s" object not found by the "%s" Argument Resolver.', $class, self::class); | ||
if ($errorMessage) { | ||
$message .= ' '.$errorMessage; | ||
} | ||
|
||
throw new NotFoundHttpException($message); | ||
} | ||
|
||
return [$object]; | ||
} | ||
|
||
private function getManager(?string $name, string $class): ?ObjectManager | ||
{ | ||
if (null === $name) { | ||
return $this->registry->getManagerForClass($class); | ||
} | ||
|
||
if (!isset($this->registry->getManagerNames()[$name])) { | ||
return null; | ||
} | ||
|
||
try { | ||
return $this->registry->getManager($name); | ||
} catch (\InvalidArgumentException) { | ||
return null; | ||
} | ||
} | ||
|
||
private function find(string $class, Request $request, MapEntity $options, string $name): false|object|null | ||
{ | ||
if ($options->mapping || $options->exclude) { | ||
return false; | ||
} | ||
|
||
$id = $this->getIdentifier($request, $options, $name); | ||
if (false === $id || null === $id) { | ||
return false; | ||
} | ||
|
||
$objectManager = $this->getManager($options->objectManager, $class); | ||
if ($options->evictCache && $objectManager instanceof EntityManagerInterface) { | ||
$cacheProvider = $objectManager->getCache(); | ||
if ($cacheProvider && $cacheProvider->containsEntity($class, $id)) { | ||
$cacheProvider->evictEntity($class, $id); | ||
} | ||
} | ||
|
||
try { | ||
return $objectManager->getRepository($class)->find($id); | ||
} catch (NoResultException|ConversionException) { | ||
return null; | ||
} | ||
} | ||
|
||
private function getIdentifier(Request $request, MapEntity $options, string $name): mixed | ||
{ | ||
if (\is_array($options->id)) { | ||
$id = []; | ||
foreach ($options->id as $field) { | ||
// Convert "%s_uuid" to "foobar_uuid" | ||
if (str_contains($field, '%s')) { | ||
$field = sprintf($field, $name); | ||
} | ||
|
||
$id[$field] = $request->attributes->get($field); | ||
} | ||
|
||
return $id; | ||
} | ||
|
||
if (null !== $options->id) { | ||
$name = $options->id; | ||
} | ||
|
||
if ($request->attributes->has($name)) { | ||
return $request->attributes->get($name); | ||
} | ||
|
||
if (!$options->id && $request->attributes->has('id')) { | ||
return $request->attributes->get('id'); | ||
} | ||
|
||
return false; | ||
} | ||
|
||
private function findOneBy(string $class, Request $request, MapEntity $options): false|object|null | ||
{ | ||
if (null === $mapping = $options->mapping) { | ||
$keys = $request->attributes->keys(); | ||
$mapping = $keys ? array_combine($keys, $keys) : []; | ||
} | ||
|
||
foreach ($options->exclude as $exclude) { | ||
unset($mapping[$exclude]); | ||
} | ||
|
||
if (!$mapping) { | ||
return false; | ||
} | ||
|
||
// if a specific id has been defined in the options and there is no corresponding attribute | ||
// return false in order to avoid a fallback to the id which might be of another object | ||
if (\is_string($options->id) && null === $request->attributes->get($options->id)) { | ||
return false; | ||
} | ||
|
||
$criteria = []; | ||
$objectManager = $this->getManager($options->objectManager, $class); | ||
$metadata = $objectManager->getClassMetadata($class); | ||
|
||
foreach ($mapping as $attribute => $field) { | ||
if (!$metadata->hasField($field) && (!$metadata->hasAssociation($field) || !$metadata->isSingleValuedAssociation($field))) { | ||
continue; | ||
} | ||
|
||
$criteria[$field] = $request->attributes->get($attribute); | ||
} | ||
|
||
if ($options->stripNull) { | ||
$criteria = array_filter($criteria, static fn ($value) => null !== $value); | ||
} | ||
|
||
if (!$criteria) { | ||
return false; | ||
} | ||
|
||
try { | ||
return $objectManager->getRepository($class)->findOneBy($criteria); | ||
} catch (NoResultException|ConversionException) { | ||
return null; | ||
} | ||
} | ||
|
||
private function findViaExpression(string $class, Request $request, string $expression, MapEntity $options): ?object | ||
{ | ||
if (!$this->expressionLanguage) { | ||
throw new \LogicException(sprintf('You cannot use the "%s" if the ExpressionLanguage component is not available. Try running "composer require symfony/expression-language".', __CLASS__)); | ||
} | ||
|
||
$repository = $this->getManager($options->objectManager, $class)->getRepository($class); | ||
$variables = array_merge($request->attributes->all(), ['repository' => $repository]); | ||
|
||
try { | ||
return $this->expressionLanguage->evaluate($expression, $variables); | ||
} catch (NoResultException|ConversionException) { | ||
return null; | ||
} | ||
} | ||
|
||
private function getOptions(ArgumentMetadata $argument): MapEntity | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. minor - but |
||
{ | ||
/** @var MapEntity $options */ | ||
$options = $argument->getAttributes(MapEntity::class, ArgumentMetadata::IS_INSTANCEOF)[0] ?? $this->defaults; | ||
|
||
return $options->withDefaults($this->defaults, $argument->getType()); | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
<?php | ||
|
||
/* | ||
* This file is part of the Symfony package. | ||
* | ||
* (c) Fabien Potencier <[email protected]> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace Symfony\Bridge\Doctrine\Attribute; | ||
|
||
/** | ||
* Indicates that a controller argument should receive an Entity. | ||
*/ | ||
#[\Attribute(\Attribute::TARGET_PARAMETER)] | ||
class MapEntity | ||
{ | ||
public function __construct( | ||
public ?string $class = null, | ||
public ?string $objectManager = null, | ||
public ?string $expr = null, | ||
public ?array $mapping = null, | ||
public ?array $exclude = null, | ||
public ?bool $stripNull = null, | ||
public array|string|null $id = null, | ||
public ?bool $evictCache = null, | ||
public bool $disabled = false, | ||
) { | ||
} | ||
|
||
public function withDefaults(self $defaults, ?string $class): static | ||
{ | ||
$clone = clone $this; | ||
$clone->class ??= class_exists($class ?? '') ? $class : null; | ||
$clone->objectManager ??= $defaults->objectManager; | ||
$clone->expr ??= $defaults->expr; | ||
$clone->mapping ??= $defaults->mapping; | ||
$clone->exclude ??= $defaults->exclude ?? []; | ||
$clone->stripNull ??= $defaults->stripNull ?? false; | ||
$clone->id ??= $defaults->id; | ||
$clone->evictCache ??= $defaults->evictCache ?? false; | ||
|
||
return $clone; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -4,6 +4,7 @@ CHANGELOG | |||||
6.2 | ||||||
--- | ||||||
|
||||||
* Add `#[MapEntity]` with its corresponding `EntityArgumentResolver` | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed in abfdc54 |
||||||
* Add `NAME` constant to `UlidType` and `UuidType` | ||||||
|
||||||
6.0 | ||||||
|
Uh oh!
There was an error while loading. Please reload this page.