Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Validator] Add Swedish translation for issue #43737 #43949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

H4wKs
Copy link
Contributor

@H4wKs H4wKs commented Nov 5, 2021

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #43737
License MIT

Added missing Swedish translation for the Validator component.

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

I think @erickr has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@erickr
Copy link
Contributor

erickr commented Nov 6, 2021

Translation make sense, is correctly spelled and have the same meaning in swedish as in English. 👍

@fabpot
Copy link
Member

fabpot commented Nov 8, 2021

Thank you @H4wKs.

@fabpot fabpot merged commit 8e59e85 into symfony:4.4 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants