Fixed FileTest::testRename to work for windows file system. #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have merged the testRename() fix but not the timezone one as you should really do that in your php.ini file. |
|
Ah yes, you are right. Thanks. |
dawehner
pushed a commit
to dawehner/symfony
that referenced
this pull request
Jul 1, 2013
add an interface for the generator to know if it has the supports method
jderusse
pushed a commit
to jderusse/symfony
that referenced
this pull request
Mar 30, 2020
Add fix from monolog
chalasr
pushed a commit
to chalasr/symfony
that referenced
this pull request
Sep 24, 2020
Added quick note about using the --dev flag
stobrien89
pushed a commit
to stobrien89/symfony
that referenced
this pull request
Feb 27, 2025
…ondition Removed an else condition
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I'm coming from the Zend Framework world. And I must say - brilliant framework. I decided to commit some of my time looking at it.
First I tried to run tests, and there are some suggestions on how to make it play nice with windows.
When i first run test, I get a number of warnings rearding timezone settings:
"Warning: It is not safe to rely on the system's timezone settings. You are required to use the date.timezone setting or the date_default_timezone_set() function. In case you used any of those methods and you are still getting this warning, you most likely misspelled the timezone identifier."
So I added it to bootstrap.
After that, I got this:
PHPUnit 3.5.5 by Sebastian Bergmann.
.................E.......................................... 60 / 1980
............................................................ 120 / 1980
............................................................ 180 / 1980
............................................................ 240 / 1980
............................................................ 300 / 1980
............................................................ 360 / 1980
............................................................ 420 / 1980
............................................................ 480 / 1980
............................................................ 540 / 1980
............................................................ 600 / 1980
............................................................ 660 / 1980
............................................................ 720 / 1980
............................................................ 780 / 1980
............................................................ 840 / 1980
.......F.................................................... 900 / 1980
............................................................ 960 / 1980
.................E.......................................... 1020 / 1980
........................................S................... 1080 / 1980
............................................................ 1140 / 1980
............................................................ 1200 / 1980
............................................................ 1260 / 1980
............................................................ 1320 / 1980
............................................................ 1380 / 1980
............................................................ 1440 / 1980
............................................................ 1500 / 1980
............................................................ 1560 / 1980
............................................................ 1620 / 1980
............................................................ 1680 / 1980
............................................................ 1740 / 1980
............................................................ 1800 / 1980
............................................................ 1860 / 1980
............................................................ 1920 / 1980
............................................................ 1980 / 1980
Time: 7 seconds, Memory: 50.50Mb
There were 2 errors:
RuntimeException: Unable to find the PHP executable.
G:\projects\PHP\symfony\src\Symfony\Component\Process\PhpProcess.php:88
G:\projects\PHP\symfony\src\Symfony\Component\Process\PhpProcess.php:58
G:\projects\PHP\symfony\src\Symfony\Component\BrowserKit\Client.php:236
G:\projects\PHP\symfony\src\Symfony\Component\BrowserKit\Client.php:206
G:\projects\PHP\symfony\tests\Symfony\Tests\Component\BrowserKit\ClientTest.php:289
RuntimeException: Unable to find the PHP executable.
G:\projects\PHP\symfony\src\Symfony\Component\Process\PhpProcess.php:88
G:\projects\PHP\symfony\src\Symfony\Component\Process\PhpProcess.php:58
G:\projects\PHP\symfony\src\Symfony\Component\BrowserKit\Client.php:236
G:\projects\PHP\symfony\src\Symfony\Component\BrowserKit\Client.php:206
G:\projects\PHP\symfony\tests\Symfony\Tests\Component\HttpKernel\ClientTest.php:53
There was 1 failure:
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-G:\projects\PHP\symfony\tests\Symfony\Tests\Component\HttpFoundation\File/Fixtures/test.target.gif
+G:\projects\PHP\symfony\tests\Symfony\Tests\Component\HttpFoundation\File\Fixtures\test.target.gif
G:\projects\PHP\symfony\tests\Symfony\Tests\Component\HttpFoundation\File\FileTest.php:109
FAILURES!
Tests: 1980, Assertions: 5015, Failures: 1, Errors: 2, Skipped: 1.
I fixed FileTest::testRename, but RuntimeException: Unable to find the PHP executable.
left unresolved, probably there is hardcoded path to /usr/bin/env php
Regards,
Saša Stamenković.