[Messenger] Leverage DBAL's getNativeConnection() method #44309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I think @tgalopin has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
|
|
|
In cache, we use In HttpFoundation, we let DBAL bootstrap a PDO Oracle connection.This code almost certainly breaks if you run it with DBAL 3. I have no Oracle test environment, I'm afraid. Otherwise, I would gladly fix it. 🙁 |
stof
approved these changes
Nov 29, 2021
fabpot
approved these changes
Nov 29, 2021
|
Thank you @derrabus. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doctrine DBAL 3 introduced a new driver middleware system that makes it difficult to unwrap the native PDO connection which we need for Messenger's Postgres transport. If an application would actually make use of the middleware system, accessing the PDO connection would become impossible for us.
Because of that, I have added a method
getNativeConnection()to DBAL with doctrine/dbal#5037. This PR leverages this new method.