Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Translation] Fix TranslationTrait #44350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2021
Merged

Conversation

tomasz-kusy
Copy link
Contributor

@tomasz-kusy tomasz-kusy commented Nov 30, 2021

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #44185
License MIT

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title Fix TranslationTrait (issue 44185) [Translation] Fix TranslationTrait (issue 44185) Nov 30, 2021
@derrabus
Copy link
Member

Can you provide a test for your change?

@nicolas-grekas nicolas-grekas changed the title [Translation] Fix TranslationTrait (issue 44185) [Translation] Fix TranslationTrait Dec 1, 2021
tomasz-kusy pushed a commit to tomasz-kusy/symfony that referenced this pull request Dec 5, 2021
@tomasz-kusy
Copy link
Contributor Author

@derrabus Ok. I've add test.

@derrabus
Copy link
Member

derrabus commented Dec 5, 2021

Thank you @tomasz-kusy.

@derrabus derrabus merged commit f35720e into symfony:5.3 Dec 5, 2021
This was referenced Dec 9, 2021
@fabpot fabpot mentioned this pull request Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants