[Translation] Make http requests synchronous when reading the Loco API #44416
Conversation
|
Checks failures are unrelated I think. |
There was a problem hiding this comment.
It is legitimate, as you profiled it and there is no big difference I'm ok to merge it. Thank you @Kocal
|
BTW, is anyone in touch with Loco, because so far they didn't answer to our ping to back the bridge. (Crowdin and Lokalise did, so you know which bridge you'd better use ;) ) |
|
The two foreach have been merged! |
|
I suggest adding a comment in the code mentioning that the Loco API forbids concurrent requests, to explain why this provider does not take advantage of the request concurrency allowed by http-client (so that it does not get refactored in the opposite way by someone not knowing about this API limitation). |
They answered us quite quickly about this issue, I contacted them via their contact form 🤷 |
|
A comment has been added, thanks for your reviews. |
|
Thank you @Kocal. |
Hi!
Since we migrated from the PHP Translation's Loco Adapter to the Symfony's Loco Translation Provider, we started to have 429 errors from the Loco API when running our CI or deploying our code on review apps/staging/production environments:
Some screenshots
We have asked to the Loco support and this is their response:
Which makes sense. AFAIK, the PHP Translation's Loco Adapter makes synchronous requests to get translations from Loco.
Some Blackfire traces, it does not impact performances:
I consider this PR as a bug-fix and not a feature, that's why I've targeted 5.3.
WDYT?
ping @welcoMattic