[DependencyInjection] Resolve ChildDefinition in AbstractRecursivePass #44418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Dec 2, 2021
| @@ -131,25 +132,35 @@ protected function getConstructor(Definition $definition, $required) | |||
|
|
|||
| if ($factory) { | |||
| [$class, $method] = $factory; | |||
|
|
|||
| if ('__construct' === $method) { | |||
There was a problem hiding this comment.
Let's throw as soon as possible?
fancyweb
commented
Dec 2, 2021
|
|
||
| try { | ||
| if (!$r = $this->container->getReflectionClass($class)) { | ||
| if (null === $class) { |
There was a problem hiding this comment.
This is a minor DX improvement. If the class is null this message looks better to me than Invalid service "foo": class "" does not exist. (see getReflectionMethod() below where we already check if a class is set or not).
nicolas-grekas
approved these changes
Dec 11, 2021
src/Symfony/Component/DependencyInjection/Tests/Compiler/AbstractRecursivePassTest.php
Outdated
Show resolved
Hide resolved
86febb1 to
acbee81
Compare
|
Thank you @fancyweb. |
This was referenced Dec 29, 2021
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least
AttributeAutoconfigurationPass(5.4 new pass) relies onAbstractRecursivePassand is executed beforeResolveChildDefinitionsPassso child definitions are not necessary resolved inAbstractRecursivePass. Doing it on 4.4 to have the same behavior on all maintained branches.It fixes #44342 in a better way because the final class of the factory can be resolved.