[FrameworkBundle] Fix compatibility with symfony/security-core 6.x (deps=high tests) #44427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be80f95 to
e044b17
Compare
wouterj
commented
Dec 2, 2021
| @@ -148,6 +153,11 @@ public function testGetUser() | |||
|
|
|||
| public function testGetUserAnonymousUserConvertedToNull() | |||
| { | |||
| // @deprecated since Symfony 5.4 | |||
| if (!class_exists(AnonymousToken::class)) { | |||
| $this->markTestSkipped('This test requires "symfony/security-core" <6.0.'); | |||
There was a problem hiding this comment.
This test is irrelevant in 6.0, as anonymous tokens are removed and anonymous sessions are now null anyways (so no conversion is needed in AbstractController::getUser()).
chalasr
approved these changes
Dec 2, 2021
wouterj
commented
Dec 2, 2021
| $token = new UsernamePasswordToken($user, 'pass', 'default', ['ROLE_USER']); | ||
| } else { | ||
| $token = new UsernamePasswordToken($user, 'default', ['ROLE_USER']); | ||
| } |
There was a problem hiding this comment.
Expected BC break, correct deprecations are triggered on 5.4.
wouterj
commented
Dec 2, 2021
| // @deprecated since Symfony 5.4 | ||
| if (method_exists($token, 'setAuthenticated')) { | ||
| $token->setAuthenticated(true); | ||
| } |
There was a problem hiding this comment.
The real bugfix of this PR, this adds support for security-core 6.0 in FrameworkBundle.
fabpot
approved these changes
Dec 3, 2021
|
Thank you @wouterj. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complete diff of this PR must be removed when upmerging to 6.0.