[Console] Handle alias in completion script #44475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
approved these changes
Dec 7, 2021
|
Thank you Jérôme! |
|
Is there a way to have this work when using the Symfony CLI with Not sure if this is a similar related to this alias limitation issue or more to the Symfony CLI symfony-cli/symfony-cli#146 but not sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect when completion is triggered by an alias and get the underlying command. Tip extracted from bamarni/symfony-console-autocomplete.
Works well with such alias:
alias console=bin/consoleDoesn't work with these aliases (command name is not the 1st part of the alias):
alias console='APP_ENV=test bin/console'When alias has a different name, the name in the completion script must be updated.