Remove UPGRADE-5.4.md #44489
Merged
Remove UPGRADE-5.4.md #44489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fancyweb
commented
Dec 7, 2021
| Q | A |
|---|---|
| Branch? | 6.0 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | - |
| License | MIT |
| Doc PR | - |
fancyweb
commented
Dec 7, 2021
UPGRADE-6.0.md
Outdated
| @@ -173,6 +173,7 @@ Messenger | |||
| * Removed the `prefetch_count` parameter in the AMQP bridge. | |||
| * Removed the use of TLS option for Redis Bridge, use `rediss://127.0.0.1` instead of `redis://127.0.0.1?tls=1` | |||
| * The `delete_after_ack` config option of the Redis transport now defaults to `true` | |||
| * The `reset_on_message` config option now defaults to `true` | |||
There was a problem hiding this comment.
This line is in branch 5.4 but not in 6.0, both files should logically be the same.
There was a problem hiding this comment.
Oh probably because it's a FWB config and not related to the Messenger component? So it should be removed in 5.4 instead?
There was a problem hiding this comment.
It needs to be removed on 5.4 then.
e1c7982 to
ff68d01
Compare
ff68d01 to
4af20e4
Compare
chalasr
approved these changes
Dec 8, 2021
ogizanagi
approved these changes
Dec 8, 2021
|
Thanks @fancyweb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.