Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove FQCN type hints on properties #44494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2021
Merged

Remove FQCN type hints on properties #44494

merged 1 commit into from
Dec 9, 2021

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Dec 7, 2021 •
edited
Loading

Q A
Branch? 6.0
Bug fix? yes
New feature? no
Deprecations? no
Tickets #44364
License MIT
Doc PR n/a

This is an alternative for #44380.
Basically, we are removing all property type hints on 6.0 and reverts that for 6.1.

@carsonbot carsonbot added this to the 6.0 milestone Dec 7, 2021
@fabpot fabpot mentioned this pull request Dec 7, 2021
Closed
fancyweb
fancyweb reviewed Dec 7, 2021
View reviewed changes
@fabpot fabpot force-pushed the preloading-fixes branch 2 times, most recently from 82499e0 to 80ea634 Compare December 8, 2021 08:40
@fabpot
Copy link
Member Author

fabpot commented Dec 8, 2021

This one is ready

@fabpot fabpot merged commit 0a13eba into symfony:6.0 Dec 9, 2021
@fabpot fabpot deleted the preloading-fixes branch December 9, 2021 12:42
fabpot added a commit that referenced this pull request Dec 9, 2021
@fabpot
Revert "bug #44494 Remove FQCN type hints on properties (fabpot)"
85065e4 
This reverts commit 0a13eba, reversing
changes made to e4cfa82.
@fabpot fabpot mentioned this pull request Dec 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof stof approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@jderusse jderusse Awaiting requested review from jderusse jderusse is a code owner

@lyrixx lyrixx Awaiting requested review from lyrixx lyrixx is a code owner

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

+1 more reviewer

@fancyweb fancyweb fancyweb left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@fabpot @nicolas-grekas @stof @fancyweb @carsonbot