[CI] Fix package-tests workflow checks for contracts #44511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Dec 9, 2021
|
Thank you @fancyweb. |
stof
reviewed
Dec 9, 2021
| _file_exist $DIR/README.md || localExit=1 | ||
| _file_not_exist $DIR/phpunit.xml || localExit=1 | ||
|
|
||
| if [ $(_jq '.new') == true ]; then | ||
| echo "Verifying new package" | ||
| _correct_license_file $DIR/LICENSE || localExit=1 | ||
|
|
||
| if [ $(_jq '.component_bridge') == false ]; then | ||
| if [ $TYPE == 'component_bridge' ]; then | ||
| if [ ! $(cat composer.json | jq -e ".replace.\"$NAME\"|test(\"self.version\")") ]; then | ||
| echo "Composer.json's replace section needs to contain $NAME" |
There was a problem hiding this comment.
why is this done only for component bridges ? bundles, normal bridges (other than the phpunit one which is special) and components (other than runtime which is a composer plugin) should also be replaced.
And contract type should be replaced in src/Symfony/Contracts/composer.json file
fancyweb
added a commit
that referenced
this pull request
Jan 3, 2022
…ection (Nyholm) This PR was merged into the 5.3 branch. Discussion ---------- [CI] If package is not bridge, it should be in replace section | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Related to #44511. Ping `@fancyweb` We should only add packages in the root composer's replace section for bundles, packages and contracts. Ie everything but bridges. Commits ------- d9f0d8e [CI] If package is not bridge, it should be in replace section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our expectations are different for contracts.