[Config] In XmlUtils, avoid converting from octal every string starting with a 0 #44537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cff633c to
0489889
Compare
stof
requested changes
Dec 9, 2021
0489889 to
0f7ccdb
Compare
0f7ccdb to
30c3913
Compare
nicolas-grekas
approved these changes
Dec 14, 2021
|
Thank you @alexandre-daubois. |
This was referenced Dec 29, 2021
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One word on the use of
intvalinstead ofoctdec:octdecleads to deprecation notices when testing a non-octal string:While
intvaldoesn't, which worth the use in my opinion.