[SecurityBundle] Make enable_authenticator_manager true as there is no other way in Symfony 6 #44554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Bundle/SecurityBundle/DependencyInjection/MainConfiguration.php
Outdated
Show resolved
Hide resolved
wouterj
requested changes
Dec 10, 2021
There was a problem hiding this comment.
We're a bit stricter with what is considered a bugfix or a feature, and given there was no bug before (just an oddity) I think we should call this a feature and target 6.1.
That would also allow us to immediately deprecating setting this option (I think there is a build in deprecate() method for this). This also resolves the description question 🙂
What do you think?
nicolas-grekas
approved these changes
Dec 11, 2021
|
I missed your comment @wouterj :) |
|
Alright, I'm OK with having this in 6.0😉 |
wouterj
approved these changes
Dec 12, 2021
|
Thanks Alexander! |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Dec 13, 2021
…s (alexander-schranz) This PR was merged into the 6.0 branch. Discussion ---------- Remove "enable_authenticator_manager" from Symfony 6 docs See symfony/symfony#44554 to avoid confusion that there is something else. Commits ------- df24637 Remove "enable_authenticator_manager" from Symfony 6 docs
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did read the new docs and I was confused about:
as I thought thats the default now and there is no other way. And that seems to case as if you set it to false it will error in:
symfony/src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php
Lines 93 to 95 in 6ab662b
So I would remove the
enable_authenticator_manageralso from the 6.0 docs and make this just the default to avod confusion here.