[SecurityBundle] Make enable_authenticator_manager true as there is no other way in Symfony 6#44554
Conversation
wouterj
left a comment
There was a problem hiding this comment.
We're a bit stricter with what is considered a bugfix or a feature, and given there was no bug before (just an oddity) I think we should call this a feature and target 6.1.
That would also allow us to immediately deprecating setting this option (I think there is a build in deprecate() method for this). This also resolves the description question 🙂
What do you think?
nicolas-grekas
left a comment
There was a problem hiding this comment.
(after the message is removed)
|
I missed your comment @wouterj :) |
|
Alright, I'm OK with having this in 6.0😉 |
|
Thanks Alexander! |
…s (alexander-schranz) This PR was merged into the 6.0 branch. Discussion ---------- Remove "enable_authenticator_manager" from Symfony 6 docs See symfony/symfony#44554 to avoid confusion that there is something else. Commits ------- df24637 Remove "enable_authenticator_manager" from Symfony 6 docs
Did read the new docs and I was confused about:
as I thought thats the default now and there is no other way. And that seems to case as if you set it to false it will error in:
symfony/src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php
Lines 93 to 95 in 6ab662b
So I would remove the
enable_authenticator_manageralso from the 6.0 docs and make this just the default to avod confusion here.