Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Cache] Fix proxy no expiration to the Redis #44577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2021
Merged

[Cache] Fix proxy no expiration to the Redis #44577

merged 1 commit into from
Dec 16, 2021

Conversation

sbelyshkin
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR

After #38156 RedisAdapter is not able to persist items with no expiration which come through ProxyAdapter because Redis does not persist keys with very large TTL such as \PHP_INT_MAX (64 bits).

@carsonbot carsonbot added this to the 4.4 milestone Dec 12, 2021
@sbelyshkin sbelyshkin force-pushed the fix-proxy-no-expiration branch 3 times, most recently from cd6cb2b to 65bf172 Compare December 12, 2021 13:58
@sbelyshkin
Copy link
Contributor Author

Looks like UnitTest fails because Redis cannot connect to getenv('REDIS_HOST') while other tests work well with this variable. How can I rewrite the test?

@carsonbot
Copy link

Hey!

I think @ajcerezo has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

nicolas-grekas
nicolas-grekas reviewed Dec 13, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, here are some comments before accepting the change.

@sbelyshkin sbelyshkin force-pushed the fix-proxy-no-expiration branch 2 times, most recently from 484407c to 8f8af9c Compare December 15, 2021 16:33
@nicolas-grekas nicolas-grekas force-pushed the fix-proxy-no-expiration branch from 8f8af9c to 0812726 Compare December 16, 2021 21:33
@nicolas-grekas
Copy link
Member

Thank you @sbelyshkin.

@nicolas-grekas nicolas-grekas merged commit aaa18df into symfony:4.4 Dec 16, 2021
This was referenced Dec 29, 2021
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Bug Cache Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@sbelyshkin @carsonbot @nicolas-grekas