Thanks to visit codestin.com
Credit goes to github.com

Skip to content

JS: use startsWith() #44593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

alexislefebvre
Copy link
Contributor

Q A
Branch? 6.1
Bug fix? no
New feature? no
Deprecations? no
Tickets Similar to #44499, but with JSFix
License MIT
Doc PR -

It's standart: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/startsWith

@carsonbot carsonbot added this to the 6.1 milestone Dec 13, 2021
@stof
Copy link
Member

stof commented Dec 13, 2021

The JS code running for the toolbar is expected to have the widest browser support possible, because this runs in the app page directly, and we don't want those pages to be restricted in their browser support just because the Symfony debug toolbar breaks the JS.
Our toolbar code is currently still compatible with IE, and this PR would break it (note that I'm specifically talking about the toolbar, not about the web profiler UI which renders its own pages)

@alexislefebvre
Copy link
Contributor Author

Thanks for the information.

My bad, I thought that IE was unsupported for 5+ years, since Edge was released.

@alexislefebvre alexislefebvre deleted the js-use-startsWith branch December 13, 2021 13:48
@stof
Copy link
Member

stof commented Dec 14, 2021

@alexislefebvre lots of enterprise tools still need to support IE due to their user base (though this is gradually going down, thanks to Microsoft pushing for the end of support of IE11).
And as Symfony has no knowledge about the intended browser support of projects, the web debug toolbar should avoid forcing to reduce that range by causing errors. for the web profiler UI, we already dropped support for IE 11 a while ago.

My bad, I thought that IE was unsupported for 5+ years, since Edge was released.

IE 11 is still supported until June 2022 on Windows 10 (after which the IE mode of the new Edge will be the only supported way to run a page needing IE on Windows 10) and until the EOL of Windows 8 (which is in 2023) on Windows 8.

@alexislefebvre
Copy link
Contributor Author

Thanks for the detailed report.

@alexislefebvre
Copy link
Contributor Author

alexislefebvre commented Jun 16, 2022

@stof can we reopen this PR now that IE is unsupported? 🙂 https://docs.microsoft.com/en-us/lifecycle/announcements/internet-explorer-11-end-of-support


Update: my bad, you already answered:

and until the EOL of Windows 8 (which is in 2023) on Windows 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants