-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Add more nullsafe operators #44659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add more nullsafe operators #44659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Dec 16, 2021
Q | A |
---|---|
Branch? | 6.1 |
Bug fix? | no |
New feature? | no |
Deprecations? | no |
Tickets | - |
License | MIT |
Doc PR | - |
79e954f
to
25fab25
Compare
GromNaN
approved these changes
Dec 16, 2021
b9bf679
to
509222e
Compare
derrabus
approved these changes
Dec 16, 2021
This PR was merged into the 6.0 branch. Discussion ---------- [Messenger] Remove pointless assignment | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Commits ------- 981cb0c Remove pointless assignment
This PR was merged into the 4.4 branch. Discussion ---------- CS fixes | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Running php-cs-fixer on the codebase Commits ------- 6e3b711 CS fixes
This PR was merged into the 4.4 branch. Discussion ---------- [Cache] disable lock on CLI | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | | Tickets | Fix symfony#41130 | License | MIT | Doc PR | - I thought using semaphores would fix the linked issue but I'm proposing to revert them in symfony#44667 Instead, I think we should disable the lock on CLI processes. The purpose of having locks enabled by default is to prevent cache stamped at deploy time. Disabling the lock on CLI still provides this protection on eg FPM. For ppl that really want a lock between eg crons and FPM, the lock component should be used instead. Commits ------- b968514 [Cache] disable lock on CLI
…y Belyshkin) This PR was merged into the 4.4 branch. Discussion ---------- [Cache] Fix proxy no expiration to the Redis | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | - <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | After symfony#38156 RedisAdapter is not able to persist items with no expiration which come through ProxyAdapter because Redis does not persist keys with very large TTL such as \PHP_INT_MAX (64 bits). Commits ------- 0812726 [Cache] Fix saving items with no expiration through ProxyAdapter
* 4.4: [Cache] Fix saving items with no expiration through ProxyAdapter CS fixes [Cache] disable lock on CLI [VarDumper] add more "transient-on-macos" groups
…g withOptions() (nicolas-grekas) This PR was merged into the 5.3 branch. Discussion ---------- [HttpClient] Fix tracing requests made after calling withOptions() | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix symfony#44312 | License | MIT | Doc PR | - Commits ------- 06b25c7 [HttpClient] Fix tracing requests made after calling withOptions()
* 5.3: [5.3] cs fixes [Cache] Fix saving items with no expiration through ProxyAdapter CS fixes [HttpClient] Fix tracing requests made after calling withOptions() [Cache] disable lock on CLI [VarDumper] add more "transient-on-macos" groups
…istry` use semaphores when possible" (nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [Cache] Revert "feature symfony#41989 make `LockRegistry` use semaphores when possible" | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix symfony#44536 | License | MIT | Doc PR | - This reverts commit 479919d, reversing changes made to 356c953. I'd like to revert this PR because using semaphores is creating problems that don't have any easy solution. Commits ------- 6bcc3cb Revert "feature symfony#41989 [Cache] make `LockRegistry` use semaphores when possible (nicolas-grekas)"
…us-code by exception works (nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [HttpKernel] fix how configuring log-level and status-code by exception works | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix symfony#44433 | License | MIT | Doc PR | - This PR replaces symfony#44456, and essentially fixes the way configuring log-level/status-code by exception works: instead of hacking them in the listener, the original exception should be wrapped in an `HttpExceptionInterface`, so that the rest of the code can seamlessly know about the configuration. Commits ------- 6617be4 [HttpKernel] fix how configuring log-level and status-code by exception works
* 5.4: [5.4] cs fixes [5.3] cs fixes [Cache] Fix saving items with no expiration through ProxyAdapter CS fixes [HttpClient] Fix tracing requests made after calling withOptions() [Cache] disable lock on CLI Revert "feature symfony#41989 [Cache] make `LockRegistry` use semaphores when possible (nicolas-grekas)" [HttpKernel] fix how configuring log-level and status-code by exception works [VarDumper] add more "transient-on-macos" groups
* 6.0: [6.0] cs fixes [5.4] cs fixes [5.3] cs fixes [Cache] Fix saving items with no expiration through ProxyAdapter CS fixes fix merge Remove pointless assignment [HttpClient] Fix tracing requests made after calling withOptions() [Cache] disable lock on CLI Revert "feature symfony#41989 [Cache] make `LockRegistry` use semaphores when possible (nicolas-grekas)" [HttpKernel] fix how configuring log-level and status-code by exception works [VarDumper] add more "transient-on-macos" groups
509222e
to
56f908a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.